Description: OmNu-Champagne is a champagne colored GTK theme collection. It supports the Cinnamon, GNOME, Openbox and XFCE desktop environments. This theme was made as a Numix clone in the Themix theme designer.
33 bad
As someone already noted, this theme does not work for Xfce 4.16, and as such, it should be either fixed, or the Xfce should be taken out of the theme description.
What's wrong with it?
No need to repeat, what has already been told, but nevertheless ...
"Looking at your OmNu-Champagne GTK-theme, it looks fine at the first sight, but on the second, it doesn't look nor function properly on Xfce 4.16, and even worse, it behaves completely different on Gnome 3 than on Xfce, which means that one of them was tweaked wrong.
From the theme packaging [Engrampa can't unpack it], over the Xfce panel / taskbar button colors, Xfwm Mini- / Maximize / Close Buttons ..., active applications icon highlighting, text color and highlighting on selected items, applications text color issues ... kinda everything wrong about it.
I used Gnome 3 as a reference for a couple of most important fixes. If you care to repair *that theme, you can drop me a mail. Don't want to publish some screenshots here and didn't make video "Everything wrong with OmNu-Champagne" yet." (by Ayleen)
One can't use Gimp upon the theme installation, for example. One gets only dark-on-dark text.
One should always test the themes which one modified!
https://www.youtube.com/watch?v=btZbBdanG3U
Jason :( You should've taken a second look at the screenshots from the YouTube comment, instead of deleting the comment. My setup is based on that screenshot, and so are my issues with your theme probably also the same, or at least very similar. I really like your theme, very nice color combinations, but it just doesn't work properly on Xfce 4.16. And, you didn't take my advice and test it before publishing. I mean, already the first slide in the OmNu slide show above isn't right. That's not exactly how the Xfce panel (== dock) should look like...
As of the new rounded panel buttons, for me personally, that would be the reason to never consider using it, but that is thankfully, unlike other issues, only the matter of personal preferences. Issues screenshot: https://ibb.co/NyQczbK
Sorry, but I did not see a comment on YouTube with any screenshot references and I certainly would not delete it.
So far as the issues referenced here, the highlighting of the app icon and buttons is part of the design. But, I will look into the other issues in the panel. Since this theme is generated with Oomox, I went with most of the code it generated.
Since this theme is generated with Oomox and you went with most of the code generated by it, the highlighting of the app icon and buttons are certainly a part of the design, just not yours, but Oomox generated failure (in) design. Namely, you wouldn't create a theme and intentionally build in mistakes. You always need to make a few tweaks, to correct the Oomox mistakes. Since I really liked your theme a lot, I made the matching IceWM theme, and I already fixed all of the issues above for myself. This is what gives: https://ibb.co/b6r16Pf | https://ibb.co/ZX6dVk4 | https://ibb.co/m97CHt8 | https://ibb.co/RSzzShY Highlighting on selected items is easy to repair, as you can see it my code-snippet on the screenshot above. Highlighting on Xfwm buttons is also easy. One just needs to create a new set of graphics, round or square, the same size, or the 2 Px smaller, with gradient, as on my 'issues screenshot' above. Any of the three sets of graphics will do, except the current one. Since I already have them done, I don't mind sharing them with you. Fixing panel buttons-background isn't that easy. There are basically 2 ways to fix it. Either one writes the code, or one uses the image. If one writes the code, one must use the IDs and classes, however not all of them react in the same way. Some buttons will need the exact panel widget ID, which is obviously a problem. Another way is to set the image with a gradient as a panel background, however, that might also become a problem when resizing the panel, as each height-change would need a new panel graphic. As of caret color, I guess you have it set on black instead of white in Oomox. Panel code-fix you can also download on my OmNu IceWM site: https://www.pling.com/p/1906527/
Hello misstell. There is now a new version of the theme that incorporates some of the code in your panel fix file. I added some of my own code as well, to my understanding of the panel design. Additionally, the Gimp caret issue has been fixed. Also, I appreciate the IceWM theme, it is good complement to the theme.
Hello Jason, better, but ... Gimp caret is fine now, and Xfwm buttons aren't protruding and cutting the line anymore, but the panel got some new issues. https://ibb.co/5v8K0K8 I didn't go into your new code, nor I did a really thorough check, but just had a quick look. On some places, now you get a double vertical line, and another issue is that there are some vertical lines on a place where there should be none at all. Namely, the application starters are one block, and they shouldn't have those lines in between of apps. Also, when checking how well does it work, remember to think of people who use the panel vertically, and try all of the available extensions! Xfce uses many extensions, and the code comes from different developers, which implement or lack different features, and the results you can see. ;) Not every extension needs the same correction, or a correction at all.
Hi Jason, sorry for the late response. Please let me show you a couple of images ... https://ibb.co/grFVhbj | https://ibb.co/jbNs6KB | https://ibb.co/KKtV08N | https://ibb.co/JkGttnG | https://ibb.co/xFqXFVq | https://ibb.co/HxC7NYX | https://ibb.co/LJjYKBs | https://ibb.co/Q6yyFjN | https://ibb.co/ZgZXrDH | https://ibb.co/25ngp9H | https://ibb.co/ZNJT7fn | https://ibb.co/qJ87hjF So, what do you think?
Ratings & Comments
11 Comments
3 3 bad As someone already noted, this theme does not work for Xfce 4.16, and as such, it should be either fixed, or the Xfce should be taken out of the theme description. What's wrong with it? No need to repeat, what has already been told, but nevertheless ... "Looking at your OmNu-Champagne GTK-theme, it looks fine at the first sight, but on the second, it doesn't look nor function properly on Xfce 4.16, and even worse, it behaves completely different on Gnome 3 than on Xfce, which means that one of them was tweaked wrong. From the theme packaging [Engrampa can't unpack it], over the Xfce panel / taskbar button colors, Xfwm Mini- / Maximize / Close Buttons ..., active applications icon highlighting, text color and highlighting on selected items, applications text color issues ... kinda everything wrong about it. I used Gnome 3 as a reference for a couple of most important fixes. If you care to repair *that theme, you can drop me a mail. Don't want to publish some screenshots here and didn't make video "Everything wrong with OmNu-Champagne" yet." (by Ayleen) One can't use Gimp upon the theme installation, for example. One gets only dark-on-dark text. One should always test the themes which one modified! https://www.youtube.com/watch?v=btZbBdanG3U
I'm working on a fix for the Gimp dark on dark text issue. Will be coming soon in an update.
Jason :( You should've taken a second look at the screenshots from the YouTube comment, instead of deleting the comment. My setup is based on that screenshot, and so are my issues with your theme probably also the same, or at least very similar. I really like your theme, very nice color combinations, but it just doesn't work properly on Xfce 4.16. And, you didn't take my advice and test it before publishing. I mean, already the first slide in the OmNu slide show above isn't right. That's not exactly how the Xfce panel (== dock) should look like... As of the new rounded panel buttons, for me personally, that would be the reason to never consider using it, but that is thankfully, unlike other issues, only the matter of personal preferences. Issues screenshot: https://ibb.co/NyQczbK
Sorry, but I did not see a comment on YouTube with any screenshot references and I certainly would not delete it. So far as the issues referenced here, the highlighting of the app icon and buttons is part of the design. But, I will look into the other issues in the panel. Since this theme is generated with Oomox, I went with most of the code it generated.
Since this theme is generated with Oomox and you went with most of the code generated by it, the highlighting of the app icon and buttons are certainly a part of the design, just not yours, but Oomox generated failure (in) design. Namely, you wouldn't create a theme and intentionally build in mistakes. You always need to make a few tweaks, to correct the Oomox mistakes. Since I really liked your theme a lot, I made the matching IceWM theme, and I already fixed all of the issues above for myself. This is what gives: https://ibb.co/b6r16Pf | https://ibb.co/ZX6dVk4 | https://ibb.co/m97CHt8 | https://ibb.co/RSzzShY Highlighting on selected items is easy to repair, as you can see it my code-snippet on the screenshot above. Highlighting on Xfwm buttons is also easy. One just needs to create a new set of graphics, round or square, the same size, or the 2 Px smaller, with gradient, as on my 'issues screenshot' above. Any of the three sets of graphics will do, except the current one. Since I already have them done, I don't mind sharing them with you. Fixing panel buttons-background isn't that easy. There are basically 2 ways to fix it. Either one writes the code, or one uses the image. If one writes the code, one must use the IDs and classes, however not all of them react in the same way. Some buttons will need the exact panel widget ID, which is obviously a problem. Another way is to set the image with a gradient as a panel background, however, that might also become a problem when resizing the panel, as each height-change would need a new panel graphic. As of caret color, I guess you have it set on black instead of white in Oomox. Panel code-fix you can also download on my OmNu IceWM site: https://www.pling.com/p/1906527/
Hello misstell. There is now a new version of the theme that incorporates some of the code in your panel fix file. I added some of my own code as well, to my understanding of the panel design. Additionally, the Gimp caret issue has been fixed. Also, I appreciate the IceWM theme, it is good complement to the theme.
Hello Jason, better, but ... Gimp caret is fine now, and Xfwm buttons aren't protruding and cutting the line anymore, but the panel got some new issues. https://ibb.co/5v8K0K8 I didn't go into your new code, nor I did a really thorough check, but just had a quick look. On some places, now you get a double vertical line, and another issue is that there are some vertical lines on a place where there should be none at all. Namely, the application starters are one block, and they shouldn't have those lines in between of apps. Also, when checking how well does it work, remember to think of people who use the panel vertically, and try all of the available extensions! Xfce uses many extensions, and the code comes from different developers, which implement or lack different features, and the results you can see. ;) Not every extension needs the same correction, or a correction at all.
Hello again misstell. Check out this latest version. I removed the extra borders and accounted for the vertical panel option.
Hi Jason, sorry for the late response. Please let me show you a couple of images ... https://ibb.co/grFVhbj | https://ibb.co/jbNs6KB | https://ibb.co/KKtV08N | https://ibb.co/JkGttnG | https://ibb.co/xFqXFVq | https://ibb.co/HxC7NYX | https://ibb.co/LJjYKBs | https://ibb.co/Q6yyFjN | https://ibb.co/ZgZXrDH | https://ibb.co/25ngp9H | https://ibb.co/ZNJT7fn | https://ibb.co/qJ87hjF So, what do you think?
9 9 excellent
8 8 great lighten the tab widget